Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): pinning pyjwt to 2.4.0 #20297

Merged
merged 3 commits into from
Jun 8, 2022
Merged

chore(deps): pinning pyjwt to 2.4.0 #20297

merged 3 commits into from
Jun 8, 2022

Conversation

sadpandajoe
Copy link
Member

SUMMARY

Missed a spot with #20287 where we were still using a lower version of pyjwt.
Here is the change log for version 2.4.0 that we are moving to.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

hughhhh
hughhhh reviewed Jun 7, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
AAfghahi
AAfghahi requested changes Jun 7, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@sadpandajoe sadpandajoe requested review from AAfghahi and hughhhh June 7, 2022 19:19
AAfghahi
AAfghahi reviewed Jun 7, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 7, 2022 •
edited
Loading

Codecov Report

Merging #20297 (805b872) into master (d1c24f8) will decrease coverage by 0.00%.
The diff coverage is 52.70%.

❗ Current head 805b872 differs from pull request most recent head 3251d96. Consider uploading reports for the commit 3251d96 to get more accurate results

@@            Coverage Diff             @@
##           master   #20297      +/-   ##
==========================================
- Coverage   66.65%   66.65%   -0.01%     
==========================================
  Files        1729     1729              
  Lines       64906    64906              
  Branches     6842     6842              
==========================================
- Hits        43266    43265       -1     
- Misses      19891    19892       +1     
  Partials     1749     1749
Flag Coverage Δ
hive 53.70% <ø> (ø)
mysql 82.28% <ø> (ø)
postgres 82.35% <ø> (ø)
presto 53.56% <ø> (ø)
python 82.77% <ø> (-0.01%) ⬇️
sqlite 82.09% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...egacy-plugin-chart-event-flow/src/controlPanel.tsx 14.28% <0.00%> (ø)
...acy-preset-chart-deckgl/src/utilities/controls.jsx 11.11% <0.00%> (ø)
...n-chart-handlebars/src/plugin/controls/columns.tsx 16.66% <0.00%> (ø)
...n-chart-handlebars/src/plugin/controls/metrics.tsx 38.46% <0.00%> (ø)
...n-chart-handlebars/src/plugin/controls/orderBy.tsx 50.00% <0.00%> (ø)
...ugin-chart-pivot-table/src/plugin/controlPanel.tsx 9.09% <0.00%> (ø)
...lLab/components/ExploreCtasResultsButton/index.tsx 8.33% <0.00%> (ø)
...ntend/src/SqlLab/components/QueryHistory/index.tsx 66.66% <ø> (ø)
...nd/src/SqlLab/components/QueryStateLabel/index.tsx 100.00% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c24f8...3251d96. Read the comment docs.

@sadpandajoe sadpandajoe requested a review from AAfghahi June 7, 2022 21:32
@AAfghahi AAfghahi merged commit d3670f1 into apache:master Jun 8, 2022
@sadpandajoe sadpandajoe deleted the joe/setting-pyjwt-package branch June 8, 2022 16:15
@sadpandajoe
Copy link
Member Author

🏷️ preset:2022.23

sadpandajoe added a commit to preset-io/superset that referenced this pull request Jun 8, 2022
@sadpandajoe
chore(deps): pinning pyjwt to 2.4.0 (apache#20297)
7341e5c 
* pinning pyjwt to 2.4.0

* Updating the max version based on PR comments

* Update setup.py

Co-authored-by: AAfghahi <[email protected]>
(cherry picked from commit d3670f1)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AAfghahi AAfghahi AAfghahi approved these changes

@hughhhh hughhhh Awaiting requested review from hughhhh

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.23 size/XS 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sadpandajoe @hughhhh @AAfghahi @mistercrunch